AstraZeneca / chemicalx

A PyTorch and TorchDrug based deep learning library for drug pair scoring. (KDD 2022)
https://chemicalx.readthedocs.io
Apache License 2.0
702 stars 89 forks source link

Add more flake8 checks #35

Closed cthoyt closed 2 years ago

cthoyt commented 2 years ago

Summary

Part of #25

This pull request adds the flake8-docstrings and a few other plugins that ensures all code is documented and other checks. It also does the very hard work of going back and documenting undocumented code.

Changes

codecov-commenter commented 2 years ago

Codecov Report

Merging #35 (4f3ff74) into main (9d10d45) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #35   +/-   ##
=======================================
  Coverage   99.48%   99.49%           
=======================================
  Files          29       29           
  Lines         587      590    +3     
=======================================
+ Hits          584      587    +3     
  Misses          3        3           
Impacted Files Coverage Δ
chemicalx/data/datasetloader.py 96.07% <ø> (ø)
chemicalx/version.py 100.00% <ø> (ø)
tests/unit/test_batching.py 100.00% <ø> (ø)
tests/unit/test_dataset.py 100.00% <ø> (ø)
tests/unit/test_datastructures.py 100.00% <ø> (ø)
chemicalx/__init__.py 100.00% <100.00%> (ø)
chemicalx/data/__init__.py 100.00% <100.00%> (ø)
chemicalx/data/batchgenerator.py 98.57% <100.00%> (+0.02%) :arrow_up:
chemicalx/data/contextfeatureset.py 100.00% <100.00%> (ø)
chemicalx/data/drugfeatureset.py 100.00% <100.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 176cddf...4f3ff74. Read the comment docs.

cthoyt commented 2 years ago

@benedekrozemberczki this is ready

benedekrozemberczki commented 2 years ago

This is amazing @cthoyt, let me merge!