Closed cthoyt closed 2 years ago
Merging #70 (82ada2b) into main (a6f2b73) will increase coverage by
0.02%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #70 +/- ##
==========================================
+ Coverage 93.74% 93.76% +0.02%
==========================================
Files 29 29
Lines 815 818 +3
==========================================
+ Hits 764 767 +3
Misses 51 51
Impacted Files | Coverage Δ | |
---|---|---|
chemicalx/data/batchgenerator.py | 98.30% <ø> (ø) |
|
chemicalx/data/contextfeatureset.py | 100.00% <ø> (ø) |
|
chemicalx/data/drugfeatureset.py | 100.00% <ø> (ø) |
|
chemicalx/data/labeledtriples.py | 100.00% <ø> (ø) |
|
chemicalx/models/deepsynergy.py | 100.00% <ø> (ø) |
|
chemicalx/models/epgcnds.py | 100.00% <ø> (ø) |
|
chemicalx/models/matchmaker.py | 95.00% <ø> (ø) |
|
chemicalx/data/datasetloader.py | 87.23% <100.00%> (+0.27%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a6f2b73...82ada2b. Read the comment docs.
Summary
This PR adds the
darglint
plugin forflake8
, whose job it is to check that documentation is provided in the correct format.Changes
darglint
to theflake8
environment intox.ini
darglint
configuration insetup.cfg
where I setsphinx
as the preferred style for chemicalx. Previously, people looked towards the numpy and google styles since they helped reduce clutter, at the cost of taking a huge number of lines and leaving tons of dead whitespace. Now that type hints are first class in the python langauge, these formats seem a bit too verbose and the sphinx style is now best again