Closed sebastiandro closed 2 years ago
@sebastiandro I will look into the segmentation indices.
Merging #74 (54143d4) into main (7cb1533) will increase coverage by
0.63%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #74 +/- ##
==========================================
+ Coverage 95.11% 95.75% +0.63%
==========================================
Files 30 32 +2
Lines 1188 1366 +178
==========================================
+ Hits 1130 1308 +178
Misses 58 58
Impacted Files | Coverage Δ | |
---|---|---|
chemicalx/models/mhcaddi.py | 100.00% <100.00%> (ø) |
|
chemicalx/utils.py | 100.00% <100.00%> (ø) |
|
tests/unit/test_models.py | 100.00% <100.00%> (ø) |
|
tests/unit/test_utils.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7cb1533...54143d4. Read the comment docs.
Will not merge without a complete rewrite of the variable names and docstrings.
After that's all done I'll take a other pass at review
@cthoyt Simplified it massively.
@cthoyt can I merge this?
Closes #13
Summary
Please provide a high-level summary of the changes for the changes and notes for the reviewers
Changes
! This is a draft, the model still need a bit of refactoring, documentation etc