AstraZeneca / rexmex

A general purpose recommender metrics library for fair evaluation.
https://rexmex.readthedocs.io/
278 stars 25 forks source link

Demonstrate annotating structured metadata to classification functions #29

Closed cthoyt closed 2 years ago

cthoyt commented 2 years ago

Summary

This PR demonstrates a potential solution to #28 in a pilot applied to classification metrics. It could be extended in a future pull request to other branches of the package.

Changes

Future

Before finalizing this PR, I had also used the annotate function to make a registry of functions. This could be used to make the generation/maintenance of the ClassificationMetricSet much easier, but I'd save that for a different PR.

codecov-commenter commented 2 years ago

Codecov Report

Merging #29 (eaf835d) into main (e3db3f6) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   99.74%   99.76%   +0.01%     
==========================================
  Files          16       16              
  Lines         781      847      +66     
==========================================
+ Hits          779      845      +66     
  Misses          2        2              
Impacted Files Coverage Δ
rexmex/metrics/classification.py 100.00% <100.00%> (ø)
rexmex/utils.py 100.00% <100.00%> (ø)
tests/unit/test_metrics.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e3db3f6...eaf835d. Read the comment docs.

benedekrozemberczki commented 2 years ago

Thank you @cthoyt!