AstraZeneca / rexmex

A general purpose recommender metrics library for fair evaluation.
https://rexmex.readthedocs.io/
278 stars 25 forks source link

Remove deprecated sklearn dependency #57

Closed dobraczka closed 1 year ago

dobraczka commented 1 year ago

Summary

Fixes #56 by removing deprecated sklearn dependency.

Changes

kajocina commented 1 year ago

I updated something on the main branch for the CI to stop failing. Could you pull the changes to your fork and update the PR? Otherwise it will keep on failing CI :)

codecov-commenter commented 1 year ago

Codecov Report

Merging #57 (a7caa1f) into main (ce492dd) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   99.37%   99.37%           
=======================================
  Files          16       16           
  Lines         953      953           
=======================================
  Hits          947      947           
  Misses          6        6           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mberr commented 1 year ago

Hi @kajocina

do you already know when you will release this fix? We are currently seeing some failing pipelines because of trying to install sklearn fetched as recursive dependency via rexmex.

kajocina commented 1 year ago

Hey @mberr

just released the 0.1.3 with this fix! Thanks for reminding us.

mberr commented 1 year ago

Thanks for the quick response and release! 🚀