quick fix type in scorecard

AstraZeneca / rexmex

A general purpose recommender metrics library for fair evaluation.

https://rexmex.readthedocs.io/

278 stars 25 forks source link

Closed kajocina closed 1 year ago

kajocina commented 1 year ago

Mypy started complaining about None not being a list (obviously)

cthoyt commented 1 year ago

definitely don't do this. Making mutable values as default parameters has lots of bad consequences.

cthoyt commented 1 year ago

The correct solution is to change the type annotation to Optional[List[str]]

kajocina commented 1 year ago

Good catch, thx!