search

Astrabit-ST / ModShot-Core

A fork of mkxp, forked for OneShot, forked for OneShot mods, (not to be confused with the ModShot server)
https://nowaffles.com
GNU General Public License v2.0
19 stars 9 forks source link

Revert "ModShot fixes and notifications/balloons" #61

Closed Speak2Erase closed 2 years ago

Speak2Erase commented 2 years ago

Reverts Astrabit-ST/ModShot-Core#60

servantoftestator commented 2 years ago

Did they forget to squash before merge or something.

Speak2Erase commented 2 years ago

No, they didn't let me review the PR, and there's some things I would like them to change first

servantoftestator commented 2 years ago

glances at commit Looks like it at a minimum could be split into two different PR's.

Speak2Erase commented 2 years ago

Look, I've never been in this situation before, and I'm no professional, give me a break.

servantoftestator commented 2 years ago

Oh sorry I wasn't trying to critique you speak2erase. I was just talking about how on hatkid's part the notifications/balloons and the minor fixes could be split into two pr's for easier review.

thehatkid commented 2 years ago

So, should I revert reverting PR and create one more PR that was code reviewed? (something like 2 PRs in total)

Speak2Erase commented 2 years ago

That would be great!