search

Astrabit-ST / ModShot-Core

A fork of mkxp, forked for OneShot, forked for OneShot mods, (not to be confused with the ModShot server)
https://nowaffles.com
GNU General Public License v2.0
19 stars 9 forks source link

Fix CI autorelease #78

Closed thehatkid closed 2 years ago

somedevfox commented 2 years ago

Nevermind.. https://github.com/marvinpinto/actions/issues/61

thehatkid commented 2 years ago

Nevermind..

Yes, Actions can't write repo contents such as releases and tags if from PR.

Speak2Erase commented 2 years ago

Release should not be triggering on pull request

somedevfox commented 2 years ago

Release should not be triggering on pull request

Hmmm, so, the solution here would be.. splitting jobs in two separate workflow files? One is for build, which is triggered on everything and one which is triggered on push-to-master?

Speak2Erase commented 2 years ago

I tried that and it didn't work very well

thehatkid commented 2 years ago

I tried that and it didn't work very well

Just maybe set trigger on workflow complete?

on:
  workflow_run:
    workflows: [ModShot CI]
    types:
      - completed
Speak2Erase commented 2 years ago

That is basically what I did

thehatkid commented 2 years ago

Release should not be triggering on pull request

Now it doesn't triggers release jobs if event is pull request.

Speak2Erase commented 2 years ago

Sounds good

Speak2Erase commented 2 years ago

Are you finished with the pr?

thehatkid commented 2 years ago

Yes I think, it builds and pre-releases on push and releases on tag creation