Astrabit-ST / ModShot-Core

A fork of mkxp, forked for OneShot, forked for OneShot mods, (not to be confused with the ModShot server)
https://nowaffles.com
GNU General Public License v2.0
19 stars 9 forks source link

Xfce4 fix wallpaper settings #86

Closed codedwrench closed 1 year ago

codedwrench commented 1 year ago

This pull requests makes it so that OneShot can set wallpapers and colors properly again on the newest xfce version.

Xfce no longer listens to monitor0 when setting a wallpaper and instead needs the display name, e.g. backdrop/screen0/monitorHDMI1/workspace0/last-image

Colors also didn't seem to work properly, so that has been changed to use rgba1 values, also using xfconf_channel_set_array instead, to make things easier

It sets the wallpaper to all monitors. Resetting when closing the game also works.

image

Speak2Erase commented 1 year ago

Hey, you might be meaning to send this pull request to mkxp-oneshot! I really do appreciate you contributing to ModShot, though.

codedwrench commented 1 year ago

I couldnt get mkxp-oneshot to compile on my system with conan, same issue as this https://github.com/elizagamedev/mkxp-oneshot/issues/36 but i might as well send the patch there too, it will probably work there