search

AstralOrdana / Immersive-Weathering

An abundance of new natural systems to make your world feel more alive than ever.
GNU Lesser General Public License v3.0
90 stars 46 forks source link

tinkers construct compat #284

Open poly-1810 opened 1 year ago

poly-1810 commented 1 year ago

Feature: basically, tinkers construct tools cant get bark from stripping trees, nor remove moss or things like that, so a compat would be nice

Alternatives:

instead of the tools required to get moss and bark being just tools, how about you just have it so that if "forge:tools/axe" interacts with logs, itll give bark

Additional info:

not much more info i can put here, but i can try writing up a PR for you

4Cloudee commented 1 year ago

I noticed the same issue while testing my modpack. I don't know if it's possible to add compatibility using datapacks, so we'll have to wait for mods author to update this mod

SiverDX commented 1 year ago

https://github.com/AstralOrdana/Immersive-Weathering/blob/1dcb0a42e697dc5974ab5393c24738f71f4a311d/common/src/main/java/com/ordana/immersive_weathering/events/ModEvents.java#L409

could be made platform specific and then use https://nekoyue.github.io/ForgeJavaDocs-NG/javadoc/1.18.2/net/minecraftforge/common/ToolActions.html on forge

Seems to also be supported by tinkers construct if I understand it correctly

https://github.com/SlimeKnights/TinkersConstruct/blob/09626c7f3f379ebe68e37312395af07b8c16e475/src/main/java/slimeknights/tconstruct/library/tools/item/ModifiableItem.java#L445