AstralOrdana / Immersive-Weathering

An abundance of new natural systems to make your world feel more alive than ever.
GNU Lesser General Public License v3.0
88 stars 42 forks source link

[Forge] Can't remove wax from Rustables (on the latest version avalible on modrth) #342

Open Pet-Slime opened 6 months ago

Pet-Slime commented 6 months ago

Describe the bug: One can't remove the wax from iron rustables that you waxed.

Other mods: this is replicable with just immersive weathering and Moonlight Lib .

Logs: [22:28:15] [Server thread/ERROR] [ne.mi.ev.EventBus/EVENTBUS]: Exception caught during firing event: null Index: 1 Listeners: 0: LOW 1: ASM: com.ordana.immersive_weathering.forge.ImmersiveWeatheringForge@370a8229 onRightClickBlock(Lnet/minecraftforge/event/entity/player/PlayerInteractEvent$RightClickBlock;)V java.lang.NullPointerException at java.base/java.util.Objects.requireNonNull(Objects.java:208) at TRANSFORMER/immersive_weathering@1.20.1-2.0.1/com.ordana.immersive_weathering.events.ModEvents.rustScraping(ModEvents.java:171) at TRANSFORMER/immersive_weathering@1.20.1-2.0.1/com.ordana.immersive_weathering.events.ModEvents.onBlockCLicked(ModEvents.java:86) at TRANSFORMER/immersive_weathering@1.20.1-2.0.1/com.ordana.immersive_weathering.forge.ImmersiveWeatheringForge.onRightClickBlock(ImmersiveWeatheringForge.java:61) at TRANSFORMER/immersive_weathering@1.20.1-2.0.1/com.ordana.immersive_weathering.forge.ImmersiveWeatheringForge_onRightClickBlock_RightClickBlock.invoke(.dynamic) at MC-BOOTSTRAP/net.minecraftforge.eventbus/net.minecraftforge.eventbus.ASMEventHandler.invoke(ASMEventHandler.java:73) at MC-BOOTSTRAP/net.minecraftforge.eventbus/net.minecraftforge.eventbus.EventBus.post(EventBus.java:315) at MC-BOOTSTRAP/net.minecraftforge.eventbus/net.minecraftforge.eventbus.EventBus.post(EventBus.java:296) at TRANSFORMER/forge@47.1.13/net.minecraftforge.common.ForgeHooks.onRightClickBlock(ForgeHooks.java:769) at TRANSFORMER/minecraft@1.20.1/net.minecraft.server.level.ServerPlayerGameMode.m_7179(ServerPlayerGameMode.java:323) at TRANSFORMER/minecraft@1.20.1/net.minecraft.server.network.ServerGamePacketListenerImpl.m_6371(ServerGamePacketListenerImpl.java:1055) at TRANSFORMER/minecraft@1.20.1/net.minecraft.network.protocol.game.ServerboundUseItemOnPacket.m5797(ServerboundUseItemOnPacket.java:34) at TRANSFORMER/minecraft@1.20.1/net.minecraft.network.protocol.game.ServerboundUseItemOnPacket.m5797(ServerboundUseItemOnPacket.java:8) at TRANSFORMER/minecraft@1.20.1/net.minecraft.network.protocol.PacketUtils.m263899(PacketUtils.java:22) at TRANSFORMER/minecraft@1.20.1/net.minecraft.server.TickTask.run(TickTask.java:18) at TRANSFORMER/minecraft@1.20.1/net.minecraft.util.thread.BlockableEventLoop.m6367(BlockableEventLoop.java:156) at TRANSFORMER/minecraft@1.20.1/net.minecraft.util.thread.ReentrantBlockableEventLoop.m6367(ReentrantBlockableEventLoop.java:23) at TRANSFORMER/minecraft@1.20.1/net.minecraft.server.MinecraftServer.m6367(MinecraftServer.java:770) at TRANSFORMER/minecraft@1.20.1/net.minecraft.server.MinecraftServer.m6367(MinecraftServer.java:161) at TRANSFORMER/minecraft@1.20.1/net.minecraft.util.thread.BlockableEventLoop.m7245(BlockableEventLoop.java:130) at TRANSFORMER/minecraft@1.20.1/net.minecraft.server.MinecraftServer.m129961(MinecraftServer.java:753) at TRANSFORMER/minecraft@1.20.1/net.minecraft.server.MinecraftServer.m7245(MinecraftServer.java:747) at TRANSFORMER/minecraft@1.20.1/net.minecraft.util.thread.BlockableEventLoop.m18701(BlockableEventLoop.java:139) at TRANSFORMER/minecraft@1.20.1/net.minecraft.server.MinecraftServer.m130012(MinecraftServer.java:733) at TRANSFORMER/minecraft@1.20.1/net.minecraft.server.MinecraftServer.m130011(MinecraftServer.java:665) at TRANSFORMER/minecraft@1.20.1/net.minecraft.server.MinecraftServer.m206580(MinecraftServer.java:251) at java.base/java.lang.Thread.run(Thread.java:833)

[22:28:15] [Server thread/ERROR] [minecraft/PacketUtils]: Failed to handle packet net.minecraft.network.protocol.game.ServerboundUseItemOnPacket@37852334, suppressing error java.lang.NullPointerException: null at java.util.Objects.requireNonNull(Objects.java:208) ~[?:?] {re:mixin} at com.ordana.immersive_weathering.events.ModEvents.rustScraping(ModEvents.java:171) ~[immersive_weathering-1.20.1-2.0.1-forge.jar%23130!/:?] {re:classloading} at com.ordana.immersive_weathering.events.ModEvents.onBlockCLicked(ModEvents.java:86) ~[immersive_weathering-1.20.1-2.0.1-forge.jar%23130!/:?] {re:classloading} at com.ordana.immersive_weathering.forge.ImmersiveWeatheringForge.onRightClickBlock(ImmersiveWeatheringForge.java:61) ~[immersive_weathering-1.20.1-2.0.1-forge.jar%23130!/:?] {re:classloading} at com.ordana.immersive_weathering.forge.ImmersiveWeatheringForge_onRightClickBlock_RightClickBlock.invoke(.dynamic) ~[immersive_weathering-1.20.1-2.0.1-forge.jar%23130!/:?] {re:classloading,pl:eventbus:B} at net.minecraftforge.eventbus.ASMEventHandler.invoke(ASMEventHandler.java:73) ~[eventbus-6.0.5.jar%23109!/:?] {} at net.minecraftforge.eventbus.EventBus.post(EventBus.java:315) ~[eventbus-6.0.5.jar%23109!/:?] {} at net.minecraftforge.eventbus.EventBus.post(EventBus.java:296) ~[eventbus-6.0.5.jar%23109!/:?] {} at net.minecraftforge.common.ForgeHooks.onRightClickBlock(ForgeHooks.java:769) ~[forge-1.20.1-47.1.13-universal.jar%23137!/:?] {re:classloading} at net.minecraft.server.level.ServerPlayerGameMode.m_7179(ServerPlayerGameMode.java:323) ~[client-1.20.1-20230612.114412-srg.jar%23132!/:?] {re:classloading} at net.minecraft.server.network.ServerGamePacketListenerImpl.m_6371(ServerGamePacketListenerImpl.java:1055) ~[client-1.20.1-20230612.114412-srg.jar%23132!/:?] {re:classloading,pl:accesstransformer:B} at net.minecraft.network.protocol.game.ServerboundUseItemOnPacket.m5797(ServerboundUseItemOnPacket.java:34) ~[client-1.20.1-20230612.114412-srg.jar%23132!/:?] {re:classloading} at net.minecraft.network.protocol.game.ServerboundUseItemOnPacket.m5797(ServerboundUseItemOnPacket.java:8) ~[client-1.20.1-20230612.114412-srg.jar%23132!/:?] {re:classloading} at net.minecraft.network.protocol.PacketUtils.m263899(PacketUtils.java:22) ~[client-1.20.1-20230612.114412-srg.jar%23132!/:?] {re:classloading} at net.minecraft.server.TickTask.run(TickTask.java:18) ~[client-1.20.1-20230612.114412-srg.jar%23132!/:?] {re:classloading} at net.minecraft.util.thread.BlockableEventLoop.m6367(BlockableEventLoop.java:156) ~[client-1.20.1-20230612.114412-srg.jar%23132!/:?] {re:classloading,pl:accesstransformer:B} at net.minecraft.util.thread.ReentrantBlockableEventLoop.m6367(ReentrantBlockableEventLoop.java:23) ~[client-1.20.1-20230612.114412-srg.jar%23132!/:?] {re:classloading} at net.minecraft.server.MinecraftServer.m6367(MinecraftServer.java:770) ~[client-1.20.1-20230612.114412-srg.jar%23132!/:?] {re:classloading,pl:accesstransformer:B,re:mixin,pl:accesstransformer:B} at net.minecraft.server.MinecraftServer.m6367(MinecraftServer.java:161) ~[client-1.20.1-20230612.114412-srg.jar%23132!/:?] {re:classloading,pl:accesstransformer:B,re:mixin,pl:accesstransformer:B} at net.minecraft.util.thread.BlockableEventLoop.m7245(BlockableEventLoop.java:130) ~[client-1.20.1-20230612.114412-srg.jar%23132!/:?] {re:classloading,pl:accesstransformer:B} at net.minecraft.server.MinecraftServer.m129961(MinecraftServer.java:753) ~[client-1.20.1-20230612.114412-srg.jar%23132!/:?] {re:classloading,pl:accesstransformer:B,re:mixin,pl:accesstransformer:B} at net.minecraft.server.MinecraftServer.m7245(MinecraftServer.java:747) ~[client-1.20.1-20230612.114412-srg.jar%23132!/:?] {re:classloading,pl:accesstransformer:B,re:mixin,pl:accesstransformer:B} at net.minecraft.util.thread.BlockableEventLoop.m18701(BlockableEventLoop.java:139) ~[client-1.20.1-20230612.114412-srg.jar%23132!/:?] {re:classloading,pl:accesstransformer:B} at net.minecraft.server.MinecraftServer.m130012(MinecraftServer.java:733) ~[client-1.20.1-20230612.114412-srg.jar%23132!/:?] {re:classloading,pl:accesstransformer:B,re:mixin,pl:accesstransformer:B} at net.minecraft.server.MinecraftServer.m130011(MinecraftServer.java:665) ~[client-1.20.1-20230612.114412-srg.jar%23132!/:?] {re:classloading,pl:accesstransformer:B,re:mixin,pl:accesstransformer:B} at net.minecraft.server.MinecraftServer.m206580(MinecraftServer.java:251) ~[client-1.20.1-20230612.114412-srg.jar%23132!/:?] {re:classloading,pl:accesstransformer:B,re:mixin,pl:accesstransformer:B} at java.lang.Thread.run(Thread.java:833) ~[?:?] {} [22:28:16] [Server thread/INFO] [minecraft/IntegratedServer]: Saving and pausing game... [22:28:16] [Server thread/INFO] [minecraft/MinecraftServer]: Saving chunks for level 'ServerLevel[New World]'/minecraft:overworld [22:28:16] [Server thread/INFO] [minecraft/MinecraftServer]: Saving chunks for level 'ServerLevel[New World]'/minecraft:the_nether [22:28:16] [Server thread/INFO] [minecraft/MinecraftServer]: Saving chunks for level 'ServerLevel[New World]'/minecraft:the_end

To Reproduce: Steps to reproduce the behavior. Format it as a numbered list of steps.

give yourself steel wool try to use steel wool on a waxed rusted block block will not unrust also works on explosed and weathered blocks as well.

Expected behavior: They are meant to become de-waxed.

AstralOrdana commented 6 months ago

why did you make a new issue for this

AstralOrdana commented 6 months ago

and you deleted the template instead of putting the mod and depenency versions into it

Pet-Slime commented 6 months ago

why did you make a new issue for this

you closed the previous one.

Pet-Slime commented 6 months ago

https://www.youtube.com/watch?v=uU49MhZt814

video reproduction of the issue while also showing the latest mod version and mod list.