AstralOrdana / Immersive-Weathering

An abundance of new natural systems to make your world feel more alive than ever.
GNU Lesser General Public License v3.0
88 stars 43 forks source link

Fixed Leaf Piles Chance #367

Closed Thiago4532 closed 4 weeks ago

Thiago4532 commented 4 months ago

The option to modify leaf pile spawn chance was removed a while ago. This commit reintroduces it and also fixes a bug that made this variable useless in the past. Instead of checking for LEAF_PILES_CHANCE before spawning a leaf, the code was comparing a random.nextFloat() with LEAF_PILES_REACH, but this value is always >= 1.0, so the piles were always spawning.

Thiago4532 commented 4 weeks ago

Thanks! Also, I think you should take a look at the default chance of a leaf pile spawning. Since before this PR the chance was 100% and now is 0.5%. Maybe this is too low, I am not sure.

AstralOrdana commented 4 weeks ago

leaf pile chance was actually baked into the block growth json file, thats why that config was removed (took me a bit to remember that)