AstralOrdana / Spelunkery

The Spelunkery mod for Minecraft
GNU Lesser General Public License v3.0
53 stars 24 forks source link

[1.19.2] Grindstone crash with Sully's Mod compat #101

Open Moofellow opened 1 year ago

Moofellow commented 1 year ago

Descriptions: Polishing Rough Jade Shards at a grindstone will crash the game. Rough Jade itself is unaffected.

Versions: Minecraft version: 1.19.2 Spelunkery version: 0.2.5 Moonlight Lib version: 2.2.43 Forge version: 43.2.21

Other mods: Fermion YUNG's Better Dungeons Habitat Easy Anvils YUNG's Better Witch Huts Player Animator Architect's Palette YUNG's Better Ocean Monuments Tips Prism YUNG's API Fins and Tails Hearth & Home Bookshelf Loot Beams Wares Bigger Stacks Shield Expansion YUNG's Better Nether Fortresses Haunted Harvest Cloth Config Dummmmmmy Geophilic Corpse Advancement Plaques Farmer's Delight Customizable Elytra 'Dustrial Decor Tool Sharpening Sleep Tight Curios Peaceful Surface Lucent YUNG's Extras YUNG's Better Strongholds Overweight Farming Architectury Windswept Sully's Mod Sulfur & Potassium Mod YUNG's Better Mineshafts Geckolib Elytra Slot Mining Helmet Nyf's Spiders Easy Magic Visual Workbench Portfolio Caelus Immersive Weathering Carpeted Golden Hopper Item Borders Decorative Blocks Snow Under Trees YUNG's Better Desert Temples Blueprint Environmental Savage & Ravage Allurement Incubation Buzzier Bees Berry Good Info Datapack Crafttweaker Mining Master Traveler's Titles Scuba Gear Chalk Pyrotastic Locksmith Etched Upgrade Aquatic Moonlight Lib Labels Spelunkery Moyai Smarter Farmers Pollen Better Combat Combat Roll Shoulder Surfing Another Furniture Oreganized Astikor Carts Atmospheric Rotten Creatures Brewin' and Chewin' Not Enough Animations Farmer's Respite Legendary Tooltips Dyed No Elytra Boosting Autumnity AutoRegLib Quark Supplementaries Supplementaries Squared Abnormals Delight Backpacked Miner's Delight Copperative Apple Skin Puzzles Lib Enhanced Celestials CorgiLib Aquaculture 2 Heartstone Better Invisibility You've Goat To Be Kidding Me Cosmetic Armor Reworked

Logs: crash-2023-07-31_21.54.42-client.txt latest.log

SiverDX commented 1 year ago

im assuming you set the depletion chance of the diamond grindstone to 0? in that case it should crash with any ore (though some ores might not get to that part of the logic I guess)

random.nextint does not like 0

Edit: Just tested it and it does happen when you set the depletion chance to 0 - but not for rough jade itself, as you said (So I guess rough jade does not get to the part where the depletion is checked)