AstralOrdana / Spelunkery

The Spelunkery mod for Minecraft
GNU Lesser General Public License v3.0
48 stars 23 forks source link

[1.20.1 Fabric] Entries in spelunkery_common.json are missing under "misc" #111

Closed pkfortis closed 1 year ago

pkfortis commented 1 year ago

Describe the bug: The following entries within the common config files on both Fabric and Forge are missing:

As such, it's actually impossible to change any of these settings.

These options are available from the config GUI using ModMenu and Cloth Config (at least in Fabric/Quilt; it's early and I can't figure out how to get access to a config GUI in Forge), but when I attempt to edit the config via in-game GUI, I get the following in the log:

[07:49:19] [Render thread/WARN]: Config file had missing entry creative_tab
[07:49:19] [Render thread/WARN]: Config file had missing entry stonecutter_damage
[07:49:19] [Render thread/WARN]: Config file had missing entry disable_diamond_grindstone_depletion
[07:49:19] [Render thread/WARN]: Config file had missing entry diamond_grindstone_deplete_chance
[07:49:19] [Render thread/WARN]: Config file had missing entry parachute_delay
[07:49:19] [Render thread/WARN]: Config file had missing entry enable_rough_gems
[07:49:19] [Render thread/WARN]: Config file had missing entry enable_raw_nuggets

Notepad++ indicates that the config file has changed after this, but no changes are apparent when the file is refreshed. This is what the config file looks like (and stays as): https://pastebin.com/ae905tu3

Versions: Minecraft version: 1.20.1 Spelunkery version: 1.20.1-0.3.1 Moonlight Lib version: 1.20-2.8.1 Fabric API version: 0.87.0+1.20.1 Fabric version: 0.14.22

This happens with Quilt as well: Quilt version: 0.19.3 Quilted Fabric API version: 7.1.1+0.86.1-1.20.1

Forge version: 47.1.44

Other mods: Tested with Cloth Config and Mod Menu (in Fabric/Quilt). Tested with Cloth Config in Forge (even though that didn't actually let me edit the config in-game). Otherwise, no other mods.

Logs: Fabric/FAPI latest.log: https://pastebin.com/AiBR0qzR

Quilt/QFAPI latest.log: https://pastebin.com/rjfjrdwm

Forge latest.log: https://pastebin.com/xKVy5Uxw Forge debug.log: https://pastebin.com/kbu0BzSb

To Reproduce:

  1. Launch the game with Spelunkery and all dependencies installed.
  2. Let the mod generate a config file.
  3. (Optional) Edit the config file via GUI (I tried Cloth Config, I'm guessing YACL would do the same thing) and save changes.
  4. Close game.
  5. Open spelunkery_common.json or spelunkery_common.toml, depending on mod loader. Behold the absence of the aforementioned sections.

Expected behavior: The mod would ideally generate a complete config file, allowing all options to be changed.

AstralOrdana commented 1 year ago

delete the config and let the mod generate a new one

pkfortis commented 1 year ago

These were new instances made specifically to test this issue. I never upgraded the mod from an older version at any point. The initially generated config file was missing the entries.

I just tried deleting it and having the mod regenerate it, and the regenerated one is still missing the entries.

pkfortis commented 1 year ago

Just to be absolutely sure, I deleted both spelunkery_common and spelunkery_client and let the mod regenerate both. Common was still missing entries.

I also just tried this with the vanilla launcher, just in case this was some weird PrismLauncher thing. It still happens. Fresh out of the box, spelunkery_common is missing the aforementioned config entries. I closed the game and deleted spelunkery_common. I relaunched the game and let the mod regenerate it. The entries are still missing.

pkfortis commented 1 year ago

So, I went back to 1.19.2, and gradually upgraded from 1.19.2-0.2.0 to 1.19.2.-0.2.5. The config options vanish at version 0.2.3. Like, the mod actually removes them from the config file on first launch after updating from 1.19.2-0.2.2 to 0.2.3.

The options are never even added to the config file in 0.3.0 or 0.3.1 over on 1.20.1. The only entry that remains under "misc" in the config file is "ore_stone_drops." If I try to add anything to that section (the missing stuff, taken from a config file from 0.2.2), the mod removes them upon launching the game.

Feel free to keep this issue closed, I guess, but I promise you I'm not trying to waste your time with this. I am genuinely encountering this issue, and it really doesn't seem to be a me problem.

pkfortis commented 1 year ago

Okay, I did some more testing this morning, and I'm not sure what my problem was yesterday, but this isn't happening with Forge, only Fabric. The only option that makes it into Fabric's config under "misc" is ore_stone_drops.

It looks like there is a set of configs that is specific to Fabric defined in CommonConfigs.java and that's the only one being used, instead of just being added to the end of the list, which I assume is the intention.