search

AstralOrdana / Spelunkery

The Spelunkery mod for Minecraft
GNU Lesser General Public License v3.0
48 stars 23 forks source link

Spelunkery and Ensorcellation compability bug #123

Open soulknitter opened 1 year ago

soulknitter commented 1 year ago

Compability issue between Spelunkery and Ensorcellation's Soulbound enchantment. When dying with an item with the Soulbound enchantment on them, the item will be duplicated into the inventory. If it's a worn armor piece, the original will stay equipped, while the duplicated one will end up in the inventory, to be more specific, in the hotbar. Effects that would affect the item upon death will be applied to both.

Possibly caused by the alterations made to the Recovery Compass

Minecraft version: 1.19.2 Spelunkery version: 1.19.2-0.2.6 Moonlight Lib version: 1.19.2-2.2.44 Forge version: 43.2.21 CoFH Core version: 1.19.2-10.2.1.40 Ensorcellation version: 1.19.2-4.2.0.14

SiverDX commented 12 months ago

It seems to be caused by https://github.com/AstralOrdana/Spelunkery/blob/main/common/src/main/java/com/ordana/spelunkery/mixins/ServerPlayerMixin.java

I'm not sure if that code part is required when using https://github.com/AstralOrdana/Spelunkery/blob/dbc586cdfb48d38e84427d282ad69c16a76f5a46/common/src/main/java/com/ordana/spelunkery/Spelunkery.java#L53

The issue does not occur anymore when disabling that mixin (and the compass is still kept) Though that could be due to some influence of other mods I have installed

Zoofule commented 3 months ago

@SiverDX

How would I go about disabling that mixin? is that something that can be done on the user level of it? I am running a server and don't want to lose soulbound, but I'll have to if I can't get the duping to stop.