AstralOrdana / Spelunkery

The Spelunkery mod for Minecraft
GNU Lesser General Public License v3.0
42 stars 20 forks source link

0.3.5 Update (1.19.2) #154

Closed SiverDX closed 5 months ago

SiverDX commented 7 months ago

Open

Advancements - saw some error messages regarding these

Magnetic compass still has the old recipe (didn't check yet if the format can just be copied or not)

No huge mushgloom (Don't wholly remember, I think because their based on cherry tree generation and other tree types turned out weird)

Moonlight API is causing problems in the DEV environment for Fabric (worked fine in "production" though)

Portal texture for Fabric might not be properly registered? Used the TextureStitch event for Forge, not sure what Fabric needs here or if it was alreay working (been some time since I last checked)

Wasn't sure what the intention for this was https://github.com/SiverDX/Spelunkery/blob/main/common/src/main/java/com/ordana/spelunkery/mixins/NoiseChunkGeneratorMixin.java


I think this is not part of the official feature set, not sure: https://github.com/SiverDX/Spelunkery/commit/7bed07057b92df6cf7bbf5cab79fad79e80f3d49

Also had to shuffle some stuff around for the startup logic due to some concurrency issues with Moonlight API

AstralOrdana commented 7 months ago

will look into issues above in testing!

SiverDX commented 5 months ago

Changed the compass recipe

Can't check out the Fabric side of things since it doesn't work in the dev environment for me And since I don't know loom / arch loom I'm not sure what to do about it (tried updating it, the moonlight dependency etc.)

See https://github.com/MehVahdJukaar/Moonlight/issues/189

At this point I already spent too much time on this Fabric thing so I'm not going to investigate it further