search

AstralOrdana / Spelunkery

The Spelunkery mod for Minecraft
GNU Lesser General Public License v3.0
42 stars 20 forks source link

[1.19.2] Block Stripe feature performance improvement #175

Closed SiverDX closed 5 months ago

SiverDX commented 5 months ago

Built on top of #154 Only new change is https://github.com/AstralOrdana/Spelunkery/pull/175/commits/15a2049e4e84456082834db34cb7b959ebeb13e6

Basically check biome first before doing the noise calls etc. Biome check also changed to access the chunk that is already present

Referenced from https://github.com/NikitaCartes-archive/MinecraftDeobfuscated-Mojang/blob/51b9f2e487507b54f417db45107fb29bcaff80a5/minecraft/src/net/minecraft/world/level/NaturalSpawner.java#L93-L95

Before

image

After

image

SiverDX commented 5 months ago

also note that the value may seem like a small % but that's normal for the world gen thread in my case this feature is the most heavy on performance worldgen-wise (when it comes to the impact of one mod)