search

AstralOrdana / Spelunkery

The Spelunkery mod for Minecraft
GNU Lesser General Public License v3.0
54 stars 26 forks source link

Random text in Bottle O' Dimensional Tears breaks stackable potion mods #201

Open MarioSMB opened 7 months ago

MarioSMB commented 7 months ago

Describe the bug: The text in bottles o' dimensional tears ("Rhymes with SCARES" and "Rhymes with FEARS") appears to be coded into the NBT or something as it makes the items unstackable when using a mod such as StackablePotions.

Versions: (BEFORE SUBMITTING A BUG REPORT, make sure you have the most up-to-date versions of Spelunkery, Moonlight Lib and Supplementaries) Minecraft version: 1.20.1 Spelunkery version: 0.3.5 Moonlight Lib version: 2.11.3 Fabric API / QSL / Forge version: 47.2.20

Other mods: StackablePotions

Logs: Even if the game does not crash they may be useful! N/A

To Reproduce: N/A

Expected behavior: It would be appreciated if this text could be handled some other way or be consistent so as to allow these items to be stacked when paired with other mods, thanks.

Screenshots: N/A

Additional info: Add any other information that might be needed.

SiverDX commented 7 months ago

image

  1. its not part of the nbt
  2. if it was it wouldnt matter because items with the same nbt can stack
MarioSMB commented 7 months ago

The behaviour is extremely inconsistent; the text appears to change every time the items are moved between slots, and when the text doesn't match they won't stack.
Also forgive me for not knowing this is not an NBT thing, I am only reporting broken behaviour that I can reproduce.

SiverDX commented 7 months ago

looked into it while tooltips are separate from nbt it does seem to have logic which is inteded to determine if a certain tooltip should display (this logic modifies the nbt and therefor causes stacking issues)

this switches every 10 seconds the item is in the inventory

steve-the-player commented 4 months ago

I believe it also has NBT data as to where it will teleport you back to, which it does even if your spawn has been updated since