AstralOrdana / Spelunkery

The Spelunkery mod for Minecraft
GNU Lesser General Public License v3.0
42 stars 19 forks source link

Salt and XP duplication #211

Open BIG-Viljo opened 2 months ago

BIG-Viljo commented 2 months ago

Describe the bug: Grinding rock salt sometimes gives more than one salt pile and some XP, which is correct, but this can be exploited by turning the newly obtained salt into rock salt and then grinding it again to get more XP and more salt leading to the ability to get infinite amounts of salt and XP without any cost.

Versions: (BEFORE SUBMITTING A BUG REPORT, make sure you have the most up-to-date versions of Spelunkery, Moonlight Lib and Supplementaries) Minecraft version: 1.20.1 Spelunkery version: 1.20.1-0.3.5 Moonlight Lib version: fabric_1.20-2.11.12 Fabric API version: 0.92.1+1.20.1

Other mods: No other mods are present other than Spelunkery, Moonlight lib and Fabric API.

Logs: Even if the game does not crash they may be useful! Please provide the following logs: Not needed as this can be fixed by simple recipe tweak.

To Reproduce: Steps to reproduce the behavior. Format it as a numbered list of steps.

  1. Get at least one salt pile
  2. Throw it/them into filled cauldron with campfire under it and water inside
  3. Get the created rock salt
  4. Grind it on a grindstone gaining XP and more salt piles
  5. Repeat infinitely from step 2.

Expected behavior: I expected 1:1 conversion without the ability to dupe.

Screenshots: Not needed.

Additional info: I'm fully aware that you can get XP and salt by smelting water buckets in furnace, but this requires fuel and time. The aforementioned exploit can be done without any cost other than a grindstone, one salt pile, campfire, cauldron and infinite water supply. Possible way on how to resolve this is removing the XP reward from grinding rock salt and rock salt:salt pile ratio should be 1:1. I couldn't tweak the recipe myself either using kube js or crafttweaker, they don't recognize the recipe type.