AstralOrdana / Spelunkery

The Spelunkery mod for Minecraft
GNU Lesser General Public License v3.0
42 stars 19 forks source link

Items taken from item frames won't stack #228

Closed BabblingFishes closed 1 month ago

BabblingFishes commented 1 month ago

Describe the bug: With Spelunkery installed, an item frame adds an empty tag:{} to the NBT data of any item placed within. This is a problem for multiple reasons, primarily because the item will not stack with untagged items of the same type. It can also cause issues for other mods/datapacks -- for example, Botania's Hopperhock filters (which use item frames) do not work due to the items in the filter being tagged (and the items you're trying to filter being untagged).

Versions: Minecraft version: 1.20.1 Spelunkery version: 1.20.1-0.3.5 Moonlight Lib version: 1.20-2.11.28 Forge version: NeoForge 47.1.105

Other mods: No other mods. This can be reproduced with only Spelunkery (1.20.1-0.3.5) and Moonlight Lib (1.20-2.11.28)

Logs: latest.log debug.log No launcher_log or hs_err exist.

To Reproduce:

  1. Place an item frame (glowing or regular, does not matter)
  2. Place a stackable item (for example, a birch sapling) inside the item frame.
  3. Remove the item.
  4. Attempt to stack the item with other items of the same type (for example, try to add it to an existing stack of 10 other birch saplings).
  5. You can easily view the NBT data of your newly-entagged item by holding the item and using /data get @p SelectedItem.

Expected behavior: Items should stack with other items of the same type. (To continue the above example, I should have one stack of 11 birch saplings.)

Screenshots: N/A

Additional info: Update: After skimming the code, I highly suspect the problem originates in common/src/main/java/com/ordana/spelunkery/mixins/ItemFrameMixin.java

BabblingFishes commented 1 month ago

Whoops, just saw this in the "fixed but not released" pile. Closing this.