search

AstralOrdana / molten-metals

Codebase of the Create: Molten Metals mod
GNU Lesser General Public License v3.0
3 stars 2 forks source link

Better forge and fabric seperation #1

Closed MrRedstoneToGo closed 5 months ago

MrRedstoneToGo commented 5 months ago

This pull request improves the recipe management in this mod.

By the way, Fabric is still loading the forge recipes because it doesn't know the forge's loading conditions. I fixed that as well.

AstralOrdana commented 5 months ago

im fairly certain that moonlight lib makes it so the forge recipe conditions can be read by fabric, though splitting the data files between the branches makes sense, I forgot you could do that

AstralOrdana commented 5 months ago

this is all very clean though, thank you so much for the pr

MrRedstoneToGo commented 5 months ago

Items related to vanilla have an empty condition but who cares.

MrRedstoneToGo commented 5 months ago

I used GitHubs find and replace. It's very practical

AstralOrdana commented 5 months ago

you used fabric:all_mods_loaded in places and looking into fabric's resource conditions, it appears there's also a fabric:any_mods_loaded but when trying to actually use that one in the mod, the recipe fails to load, are you familiar with this system enough to know why that might be?

MrRedstoneToGo commented 5 months ago

Where did you see that there is fabric:any_mods_loaded? I just took the load conditions from Create Fabric. Alternatively, try writing the alternative mods in the array of fabric:load_conditions as a second condition. Maybe this will work as desired.