search

AstralOrdana / molten-metals

Codebase of the Create: Molten Metals mod
GNU Lesser General Public License v3.0
3 stars 2 forks source link

double recipes #2

Closed Lucky-56 closed 5 months ago

Lucky-56 commented 5 months ago

although both recipes are tag based, both are loaded at the same time

Versions: Minecraft version: 1.20.1 Molten Metals version: 0.1.3 Forge version: 47.2.32

2024-05-18_00 50 19 2024-05-18_00 50 21

Lucky-56 commented 5 months ago

exists for all silver related recipes

AstralOrdana commented 5 months ago

this is a natural concequence of loading oreganized and galosphere at the same time, the recipes dont interfere and fixing this would be non-trivial

Lucky-56 commented 5 months ago

why have two recipes in the first place tho, as they literally added tags for this

sorry, just seems sloppy to me

AstralOrdana commented 5 months ago

the recipe does use tags, and as you can see they are functionally identical with their inputs and outputs. the reason they exist as two separate recipes is their loading conditions, one is added if oreganized is loaded, the other if it detects galosphere. forge recipe conditions don't let you do an any-of check so this is the best i can do.

AJBuilder commented 3 months ago

Does the forge:or condition not work? Am I missing something?

I made this change on my fork. Pr is https://github.com/AstralOrdana/molten-metals/pull/8