AstroDraw / AstroChart

A free and open-source TypeScript library for generating SVG charts to display planets in astrology.
https://astrodraw.github.io
MIT License
212 stars 55 forks source link

Conjunction aspect is not drawn #27

Open ilyai opened 2 years ago

ilyai commented 2 years ago

Describe the bug In the aspects settings there's a configuration for conjunction aspect: https://github.com/AstroDraw/AstroChart/blob/main/project/src/settings.js#L170 , but even when I've changed the color from transparent to some other color I still don't see any changes in the chart.

To Reproduce Steps to reproduce the behavior:

  1. Change the color from transparent to some other color in the settings of conjunction aspect
  2. Make sure that conjunction aspect should exist according to the data you're passing
  3. Refresh the chart and check it

Expected behavior Conjunction aspect should be displayed visually somehow. Here are the examples from other astrology chart apps:

image image

Screenshots N/A

Additional info (please complete the following information):

Additional context N/A

afucher commented 2 years ago

I take a look and seems that we have 2 bugs:

image

This would take more time to resolve, since I need to check the best way to show the conjunction. Feel free to contribute with your suggestion, or solving the hasAspect bug.