search

AstroHackWeek / AstroHackWeek2019

22 stars 36 forks source link

Switch to more conventional matplotlib import #19

Closed eteq closed 5 years ago

eteq commented 5 years ago

This PR makes the minor suggestion of changing the pyplot imports in the day3 bayes exercises to use plt as the short form of pyplot instead of of mp - this is the traditional convention the matplotlib team generally recommends.

bsipocz commented 5 years ago

cc @sfeeney - could you please confirm you're OK with changing this?

eteq commented 5 years ago

(should have noted in the description that I did briefly chat with @sfeeney about this, but should also get confirmation here since he was busy actually teaching the tutorial at the time, of course!)

bsipocz commented 5 years ago

Oh, if he was looped in it already, I'm happy to hit merge any time.

bsipocz commented 5 years ago

Hmm, looking into the notebooks I would also suggest to change the scipy imports. Keeping the full spelling of the scipy and numpy imports would make the notebook more clear I think.

sfeeney commented 5 years ago

Hi all!

I'm happy to change whatever imports desired to maintain clarity. I just used my standard shorthand as we were low on time :)

Cheers!

Stephen

On Wed, Aug 28, 2019 at 12:45 PM Brigitta Sipocz notifications@github.com wrote:

Hmm, looking into the notebooks I would also suggest to change the scipy imports. Keeping the full spelling of the scipy and numpy imports would make the notebook more clear I think.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AstroHackWeek/AstroHackWeek2019/pull/19?email_source=notifications&email_token=AB34WEALWTJWUT3YWDAD723QGZQNFA5CNFSM4IRBF2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5K2VBY#issuecomment-525707911, or mute the thread https://github.com/notifications/unsubscribe-auth/AB34WED6AJ22TAHJDTQXAODQGZQNFANCNFSM4IRBF2AQ .

bsipocz commented 5 years ago

Thanks both. I'm merging this now, but may open another PR for the other imports.