search

AstroHuntsman / gunagala

4 stars 9 forks source link

swapped self.wcs._naxis in make_noiseless_image? #18

Closed lspitler closed 5 years ago

lspitler commented 6 years ago

I think on line:

https://github.com/AstroHuntsman/gunagala/blob/7b6fcbfe892341cb4ec7a672ec4f04c064d2e866/gunagala/imager.py#L1562

The naxis should be swapped? Found this using rectangular image and square PSF.

lspitler commented 5 years ago

@bazkiaei I believe this is the Issue you're dealing with with the current PR?

bazkiaei commented 5 years ago

@bazkiaei I believe this is the Issue you're dealing with with the current PR?

I think we fixed it within Fix axis 18 WIP.

lspitler commented 5 years ago

OK, @bazkiaei closing this issue. Though @AnthonyHorton feel free to re-open.

AnthonyHorton commented 5 years ago

@lee Would be good to confirm that #20 has indeed fixed this. It should have though.

lspitler commented 5 years ago

@AnthonyHorton just verified it works without any issues. Nice job @bazkiaei !