search

AstroHuntsman / gunagala

4 stars 9 forks source link

Fix create imagers #41

Closed danjampro closed 3 years ago

danjampro commented 3 years ago

Fixes a problem where the xrange and yrange parsed to discretize_model in the PSF code contained floating point values. This caused create_imagers to fail.

lspitler commented 3 years ago

@danjampro astropy have released the version which fixes this problem, so it should work now: https://github.com/astropy/astropy/releases/tag/v4.0.2 via: pip install astropy==4.0.2

My pending PR #39 includes a astropy>=4.02 requirement, so I think this PR/branch are not needed. So I'm closing this PR.

wtgee commented 3 years ago

Note that astropy >4.0.3 will currently break astroplan (astropy/astroplan#485). That will hopefully be fixed in the next day or so.