Closed danjampro closed 3 years ago
Merging #195 (adc35a8) into develop (e195a24) will increase coverage by
0.32%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## develop #195 +/- ##
===========================================
+ Coverage 91.25% 91.58% +0.32%
===========================================
Files 37 37
Lines 2322 2376 +54
===========================================
+ Hits 2119 2176 +57
+ Misses 203 200 -3
Impacted Files | Coverage Δ | |
---|---|---|
...ntsman-drp/src/huntsman/drp/collection/exposure.py | 94.64% <0.00%> (-0.04%) |
:arrow_down: |
huntsman-drp/src/huntsman/drp/utils/testing.py | 88.06% <0.00%> (+0.06%) |
:arrow_up: |
huntsman-drp/src/huntsman/drp/collection/calib.py | 98.63% <0.00%> (+0.55%) |
:arrow_up: |
huntsman-drp/src/huntsman/drp/metrics/evaluator.py | 84.61% <0.00%> (+0.61%) |
:arrow_up: |
...sman-drp/src/huntsman/drp/collection/collection.py | 87.24% <0.00%> (+2.68%) |
:arrow_up: |
huntsman-drp/src/huntsman/drp/metrics/raw.py | 86.66% <0.00%> (+3.68%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e195a24...adc35a8. Read the comment docs.
Adds support for reference calibs, which can be compared to raw calibs on ingestion (i.e. by the
MetricEvaluator
). Currently, these images can be used as templates to assess the quality of incoming raw calibs through the reduced chi2 statistic.The filenames of reference calibs should be listed in the local config under the heading
reference_calib_filenames
. The new scriptingest-reference-calibs.py
should be used to manually ingest these files, ideally before restarting theCalibService
.NOTE: The reduced chi2 statistic should be implemented as a quality cut in the config once we have gathered enough reference calibs