AstroHuntsman / huntsman-drp

Imaging pipeline tools and flow.
MIT License
0 stars 2 forks source link

Handle case where headers dont contain mount ra/dec #210

Closed fergusL closed 1 year ago

fergusL commented 2 years ago

Some files have missing mount Ra/Dec info, which triggers an error that prevents file ingestion. By propagating None values instead, the pointing info will be filled in by the astrometry ingest metric.

codecov[bot] commented 1 year ago

Codecov Report

Base: 91.61% // Head: 91.23% // Decreases project coverage by -0.37% :warning:

Coverage data is based on head (e80ff93) compared to base (00f045c). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #210 +/- ## =========================================== - Coverage 91.61% 91.23% -0.38% =========================================== Files 37 37 Lines 2397 2431 +34 =========================================== + Hits 2196 2218 +22 - Misses 201 213 +12 ``` | [Impacted Files](https://codecov.io/gh/AstroHuntsman/huntsman-drp/pull/210?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AstroHuntsman) | Coverage Δ | | |---|---|---| | [huntsman-drp/src/huntsman/drp/lsst/utils/butler.py](https://codecov.io/gh/AstroHuntsman/huntsman-drp/pull/210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AstroHuntsman#diff-aHVudHNtYW4tZHJwL3NyYy9odW50c21hbi9kcnAvbHNzdC91dGlscy9idXRsZXIucHk=) | `68.75% <0.00%> (-21.88%)` | :arrow_down: | | [huntsman-drp/src/huntsman/drp/utils/fits.py](https://codecov.io/gh/AstroHuntsman/huntsman-drp/pull/210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AstroHuntsman#diff-aHVudHNtYW4tZHJwL3NyYy9odW50c21hbi9kcnAvdXRpbHMvZml0cy5weQ==) | `92.85% <0.00%> (-7.15%)` | :arrow_down: | | [huntsman-drp/src/huntsman/drp/utils/header.py](https://codecov.io/gh/AstroHuntsman/huntsman-drp/pull/210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AstroHuntsman#diff-aHVudHNtYW4tZHJwL3NyYy9odW50c21hbi9kcnAvdXRpbHMvaGVhZGVyLnB5) | `89.06% <0.00%> (-2.17%)` | :arrow_down: | | [huntsman-drp/src/huntsman/drp/utils/date.py](https://codecov.io/gh/AstroHuntsman/huntsman-drp/pull/210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AstroHuntsman#diff-aHVudHNtYW4tZHJwL3NyYy9odW50c21hbi9kcnAvdXRpbHMvZGF0ZS5weQ==) | `93.61% <0.00%> (+0.06%)` | :arrow_up: | | [huntsman-drp/src/huntsman/drp/utils/mongo.py](https://codecov.io/gh/AstroHuntsman/huntsman-drp/pull/210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AstroHuntsman#diff-aHVudHNtYW4tZHJwL3NyYy9odW50c21hbi9kcnAvdXRpbHMvbW9uZ28ucHk=) | `93.65% <0.00%> (+0.10%)` | :arrow_up: | | [huntsman-drp/src/huntsman/drp/utils/testing.py](https://codecov.io/gh/AstroHuntsman/huntsman-drp/pull/210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AstroHuntsman#diff-aHVudHNtYW4tZHJwL3NyYy9odW50c21hbi9kcnAvdXRpbHMvdGVzdGluZy5weQ==) | `88.33% <0.00%> (+0.19%)` | :arrow_up: | | [huntsman-drp/src/huntsman/drp/reduction/lsst.py](https://codecov.io/gh/AstroHuntsman/huntsman-drp/pull/210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AstroHuntsman#diff-aHVudHNtYW4tZHJwL3NyYy9odW50c21hbi9kcnAvcmVkdWN0aW9uL2xzc3QucHk=) | `92.50% <0.00%> (+0.60%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AstroHuntsman). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AstroHuntsman)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.