search

AstroHuntsman / huntsman-pocs

POCS on the Huntsman Telescope
MIT License
7 stars 8 forks source link

Convert voltage to float #372

Closed JAAlvarado-Montes closed 3 years ago

JAAlvarado-Montes commented 3 years ago

This small PR fixes a bug where voltage if being left as string and not converted to float.

codecov[bot] commented 3 years ago

Codecov Report

Merging #372 (5cf8ca5) into develop (f389ad8) will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #372   +/-   ##
========================================
  Coverage    54.40%   54.40%           
========================================
  Files           59       59           
  Lines         3334     3334           
  Branches       349      349           
========================================
  Hits          1814     1814           
  Misses        1433     1433           
  Partials        87       87
Impacted Files Coverage Δ
src/huntsman/pocs/dome/musca.py 34.31% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f389ad8...fbae24e. Read the comment docs.

JAAlvarado-Montes commented 3 years ago

Is that better @AnthonyHorton ? Just addressed your comments :)