Closed danjampro closed 3 years ago
Merging #408 (4d746e5) into develop (18cdc60) will increase coverage by
0.58%
. The diff coverage is100.00%
.:exclamation: Current head 4d746e5 differs from pull request most recent head 9b19995. Consider uploading reports for the commit 9b19995 to get more accurate results
@@ Coverage Diff @@
## develop #408 +/- ##
===========================================
+ Coverage 54.75% 55.34% +0.58%
===========================================
Files 62 62
Lines 3689 3733 +44
Branches 380 386 +6
===========================================
+ Hits 2020 2066 +46
+ Misses 1583 1582 -1
+ Partials 86 85 -1
Impacted Files | Coverage Δ | |
---|---|---|
src/huntsman/pocs/scheduler/observation/base.py | 74.49% <100.00%> (+2.03%) |
:arrow_up: |
tests/test_scheduler.py | 100.00% <100.00%> (ø) |
|
src/huntsman/pocs/archive/archiver.py | 90.65% <0.00%> (+1.86%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 18cdc60...9b19995. Read the comment docs.
The
POCS
scheduler requires all field objects to be astropyFixedTarget
instances. This meansobservation.field
should always return ahuntsman.pocs.scheduler.field.Field
object, rather than e.g. ahuntsman.pocs.scheduler.field.CompoundField
. This was problematic when creating nestedCompoundField
objects, asobservation.field
currently would return an instance ofhuntsman.pocs.scheduler.field.CompoundField
.Logic and docstrings updated accordingly. Do not merge until tested on Huntsman and new unit tests are added.