search

AstroHuntsman / huntsman-pocs

POCS on the Huntsman Telescope
MIT License
7 stars 8 forks source link

Fix scheduler loop and astromech position getter #510

Closed danjampro closed 2 years ago

danjampro commented 2 years ago

It seems that the problem occurs after completing the first set of observations. After that, the condition set_is_finished evaluates to True when entering take_observation_block, so nothing happens. The solution is to force take_observation_block to begin a new set.

Also fixes the pyro serialisation problem for astromech focuser.position.

Related: #486 Closes #508

codecov[bot] commented 2 years ago

Codecov Report

Merging #510 (94dc87b) into develop (296f48c) will decrease coverage by 0.45%. The diff coverage is 25.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #510      +/-   ##
===========================================
- Coverage    56.15%   55.70%   -0.46%     
===========================================
  Files           60       60              
  Lines         3939     3944       +5     
  Branches       414      411       -3     
===========================================
- Hits          2212     2197      -15     
- Misses        1623     1647      +24     
+ Partials       104      100       -4
Impacted Files Coverage Δ
src/huntsman/pocs/focuser/astromechanics.py 0.00% <0.00%> (ø)
src/huntsman/pocs/scheduler/observation/base.py 75.32% <ø> (-0.16%) :arrow_down:
src/huntsman/pocs/observatory.py 57.97% <28.57%> (-4.22%) :arrow_down:
src/huntsman/pocs/scheduler/observation/dark.py 80.00% <0.00%> (-6.67%) :arrow_down:
src/huntsman/pocs/archive/archiver.py 90.00% <0.00%> (+1.81%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 296f48c...94dc87b. Read the comment docs.