Closed fergusL closed 2 years ago
Merging #543 (fef59ce) into develop (e1458a0) will decrease coverage by
1.75%
. The diff coverage is38.98%
.
@@ Coverage Diff @@
## develop #543 +/- ##
===========================================
- Coverage 56.54% 54.79% -1.76%
===========================================
Files 60 64 +4
Lines 3901 4121 +220
Branches 421 456 +35
===========================================
+ Hits 2206 2258 +52
- Misses 1580 1740 +160
- Partials 115 123 +8
Impacted Files | Coverage Δ | |
---|---|---|
src/huntsman/pocs/camera/simulator/camera.py | 0.00% <0.00%> (ø) |
|
src/huntsman/pocs/camera/utils.py | 72.36% <ø> (+0.09%) |
:arrow_up: |
src/huntsman/pocs/camera/zwo.py | 0.00% <0.00%> (ø) |
|
src/huntsman/pocs/utils/safety.py | 44.44% <ø> (+3.96%) |
:arrow_up: |
src/huntsman/pocs/utils/weather.py | 0.00% <0.00%> (ø) |
|
src/huntsman/pocs/core.py | 51.61% <25.00%> (-4.49%) |
:arrow_down: |
src/huntsman/pocs/camera/group.py | 66.34% <50.00%> (-0.33%) |
:arrow_down: |
src/huntsman/pocs/scheduler/observation/base.py | 73.05% <69.23%> (-0.67%) |
:arrow_down: |
src/huntsman/pocs/camera/camera.py | 71.81% <71.81%> (ø) |
|
src/huntsman/pocs/scheduler/observation/bias.py | 87.50% <87.50%> (ø) |
|
... and 7 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update deab519...fef59ce. Read the comment docs.
@danjampro looks like @fergusL needs a final review?
merging so @fergusL can test it tomorrow.
Created new
AbstractHuntsmanCamera
base class so thatobservation.filter_name
can be overriden on a per camera basis. Also moved exposure time tuning fromCameraGroup
intoAbstractHuntsmanCamera
base calss.