AstroHuntsman / huntsman-pocs

POCS on the Huntsman Telescope
MIT License
7 stars 8 forks source link

update Altitude Constraint for CompoundObs #574

Closed fergusL closed 1 year ago

fergusL commented 1 year ago

Altitude constraint need to assess all the fields within a CompoundObservation instead of just the first field (ie need to check altitude of sci target and the sky field)

resolves #504

codecov[bot] commented 1 year ago

Codecov Report

Base: 55.67% // Head: 55.41% // Decreases project coverage by -0.26% :warning:

Coverage data is based on head (d051dd6) compared to base (0d43d8f). Patch coverage: 23.33% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #574 +/- ## =========================================== - Coverage 55.67% 55.41% -0.27% =========================================== Files 65 65 Lines 4214 4241 +27 Branches 553 560 +7 =========================================== + Hits 2346 2350 +4 - Misses 1743 1766 +23 Partials 125 125 ``` | [Impacted Files](https://codecov.io/gh/AstroHuntsman/huntsman-pocs/pull/574?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AstroHuntsman) | Coverage Δ | | |---|---|---| | [src/huntsman/pocs/scheduler/constraint.py](https://codecov.io/gh/AstroHuntsman/huntsman-pocs/pull/574/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AstroHuntsman#diff-c3JjL2h1bnRzbWFuL3BvY3Mvc2NoZWR1bGVyL2NvbnN0cmFpbnQucHk=) | `37.25% <17.85%> (-25.25%)` | :arrow_down: | | [src/huntsman/pocs/utils/huntsman.py](https://codecov.io/gh/AstroHuntsman/huntsman-pocs/pull/574/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AstroHuntsman#diff-c3JjL2h1bnRzbWFuL3BvY3MvdXRpbHMvaHVudHNtYW4ucHk=) | `76.11% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AstroHuntsman). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AstroHuntsman)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.