search

AstroImageJ / astroimagej

http://astroimagej.com
GNU General Public License v3.0
15 stars 10 forks source link

Update build.gradle #34

Closed fvarrui closed 3 years ago

fvarrui commented 3 years ago

It seems like Gradle is using an embedded version of JavaPackager or something like that. I've managed to reproduce your issue and fix it only uncomment mavenLocal() repo. I'm not sure if this is a good solution for you, but, it works! 😄

keastrid commented 3 years ago

Many thanks @fvarrui ! I'm going to close this as the bundling of JavaPackager in the repo is intentional as I'm not the only one working on this, so maven local doesn't work well; this project is a major update with a complete redesign of the distributions and we're in the process of getting ready for a release sometime soon, so quick iterations on the packaging was needed. The bundling is also a bit of a remnant of the updates made to support newer gradle/java versions before they were merged.

That said, this did point me in the right direction - I've only been updating the jar, and the deps updated this time. Guess we were just lucky before.

Thank you for making JavaPackager, its been great to work with and has been a very approachable setup. Your help has also been great. Have a great holiday, and thanks again for taking the time review PRs and bugfix!

fvarrui commented 3 years ago

Thanks to you for helping to improve JavaPackager, has grown a lot with your contributions!