Closed gabrielscaranello closed 1 month ago
Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:
Proper conventional commit scoping:
If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin
If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error
[x] Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above
[x] README
is properly formatted and uses fenced in links with <url>
unless they are inside a [title](url)
[x] Proper usage of opts
table rather than setting things up with the config
function.
Have you tested this to make sure it works? Do we also need to reenable hybrid mode for volar?
Idk anything about this process but the code looks fine. I saw we just merge it if the user says they have actually tested it.
I tested it on three projects and it worked as expected. Enable hybrid mode works at first glance, but causes duplications in cmp entries and strange behavior in TS projects that don't use Vue.
Ok cool! Then looks good to me! :shipit:
📑 Description
Add Volar as a tsserver plugin, configured with vtsls.
ℹ Additional Information
In
volar >= 2.0
, some synchronization problems between tsserver and volar appear, causing errors when working with .ts and .vue files at the same time.An issue for this is being tracked (yioneko/vtsls#148)