Closed Kamilcuk closed 1 week ago
Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:
Proper conventional commit scoping:
If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin
If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error
[x] Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above
[x] README
is properly formatted and uses fenced in links with <url>
unless they are inside a [title](url)
[x] Proper usage of opts
table rather than setting things up with the config
function.
Your mappings are wrong.
Fixing them myself.
@Kamilcuk Can you test it now? :)
Hi @Uzaaft .
Can you test it now?
I copied the code to my plugins/ and confirm it works nicely.
clarification: So here the code was changed from dependencies = { "astrocore", opts = { mappings =
into opts = function(_ , opts) opts.mappigs[...] = ...
. Please kindly satisfy my curiosity. What was the reason for the change?
nonblocking, cosmetics: I am suprised by the choice of ó°¹ as the icon and I prefer and also observe the usage of 🤖 for chatgpt. But I don't care.
LGTM
Thanks.
@maxbrunet How about you, did you test it as well? I think we can combine the changes from your branch into this one if you'd prefer, feel free to suggest those and I'll commit them :)
@Kamilcuk I'll give you the reason of the change whenever I have time to write an explanation. Might take a while before I have time.
📑 Description
Chatgpt.nvim has mapping recommendation in their readme. I think it makes a nice addition under
<leader>G
,G
like gpt. I typically use<space>Gc
to start a chat. Let me know what you think.ℹ Additional Information