AstroNvim / astrocommunity

A community repository of common plugin specifications
GNU General Public License v3.0
1.04k stars 212 forks source link

feat(chatgpt-nvim): add which-key mappings below <leader>G #1051

Closed Kamilcuk closed 1 week ago

Kamilcuk commented 1 week ago

📑 Description

Chatgpt.nvim has mapping recommendation in their readme. I think it makes a nice addition under <leader>G, G like gpt. I typically use <space>Gc to start a chat. Let me know what you think.

image

image

ℹ Additional Information

github-actions[bot] commented 1 week ago

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

Uzaaft commented 1 week ago

Your mappings are wrong.

Uzaaft commented 1 week ago

Fixing them myself.

Uzaaft commented 1 week ago

@Kamilcuk Can you test it now? :)

Kamilcuk commented 1 week ago

Hi @Uzaaft .

Can you test it now?

I copied the code to my plugins/ and confirm it works nicely.

clarification: So here the code was changed from dependencies = { "astrocore", opts = { mappings = into opts = function(_ , opts) opts.mappigs[...] = .... Please kindly satisfy my curiosity. What was the reason for the change?

nonblocking, cosmetics: I am suprised by the choice of 󰭹 as the icon and I prefer and also observe the usage of 🤖 for chatgpt. But I don't care.

LGTM

Thanks.

Uzaaft commented 1 week ago

@maxbrunet How about you, did you test it as well? I think we can combine the changes from your branch into this one if you'd prefer, feel free to suggest those and I'll commit them :)

@Kamilcuk I'll give you the reason of the change whenever I have time to write an explanation. Might take a while before I have time.