fix(go): set default go binary to `"go"`

rami3l commented 1 week ago

📑 Description

This prevents the error message that comes with the newer versions of go.nvim:

  if vim.fn.empty(_GO_NVIM_CFG.go) == 1 then
    vim.notify('go.nvim go binary is not setup', vim.log.levels.ERROR)
  end

I think the author could've given a good default to this value and make it overridable instead of issuing a hard error, but alas...

Tested with the following config override locally:

  { "ray-x/go.nvim", opts = { go = "go" } },

github-actions[bot] commented 1 week ago

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin
If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error
[x] Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above
[x] README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)
[x] Proper usage of opts table rather than setting things up with the config function.

Uzaaft commented 1 week ago

The fact that this is needed due to the hard error is just stupid...Thanks!