Closed WilliamBy closed 1 week ago
Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:
Proper conventional commit scoping:
If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin
If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error
[x] Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above
[x] README
is properly formatted and uses fenced in links with <url>
unless they are inside a [title](url)
[x] Proper usage of opts
table rather than setting things up with the config
function.
~We should hold off until this PR is merged: https://github.com/williamboman/mason-lspconfig.nvim/pull/428~
If we get the changes I requested merged in, I can always just do a follow up PR to simplify this once the mason-lspconfig
PR is merged
Once the PR to mason-lspconfig
is merged we should simplify the AstroLSP configuration as well as add:
{
"williamboman/mason-lspconfig.nvim",
optional = true,
opts = function(_, opts)
opts.ensure_installed = require("astrocore").list_insert_unique(opts.ensure_installed, { "hyprls" })
end,
},
Ok, I just did a follow up revision of this PR to rename this to hyprlang
pack just because that is technically the name of the configuration language rather than hyprland
Thanks for the contribution! This is a great one! :D Love seeing packs getting added that really decrease setup like setting up filetypes and things 😄
📑 Description
ℹ Additional Information