AstroNvim / astrocommunity

A community repository of common plugin specifications
GNU General Public License v3.0
1.21k stars 242 forks source link

neotest should respect when icons_enabled is false #1207

Closed windowsrefund closed 2 months ago

windowsrefund commented 2 months ago

Checklist

Neovim version (nvim -v)

doesn't matter

Operating system/version

does not matter

Terminal/GUI

does not matter

Describe the bug

neotest forces icons but the user may have chosen to disable them

Steps to Reproduce

use the community pack

Expected behavior

pack should respect the higher level icon_enabled boolean linked above.

Screenshots

No response

Additional Context

No response

Minimal configuration

-- not required
Uzaaft commented 2 months ago

Minimal configuration is required. Please fill it in @windowsrefund

windowsrefund commented 2 months ago

There's no need as it wouldn't contribute to the perfectly described issue.

Uzaaft commented 2 months ago

We require a minimal configuration. You'll have to fill it in.

Uzaaft commented 2 months ago

We're literally asking you to do the bare minimum.

windowsrefund commented 2 months ago

and I am LITERALLY (I know you kids love to use this word to overly sensationalize your communications) telling you the information provided is enough to act on. TBH, I don't care if this gets fixed or not. Feel free to close it.

windowsrefund commented 2 months ago

literally! :+1:

luxus commented 2 months ago

https://github.com/AstroNvim/astrocommunity/blob/283ca3c0b1b06216860475834501628482e7c3c5/lua/astrocommunity/icon/mini-icons/init.lua#L3-L5 a check like this could fix the issue