feat(go): Add golangcilint as default linter

[shivanthzen]

📑 Description

The PR adds golangcilint as the default linter for go.pack. Currently no linters as part for the pack.

ℹ Additional Information

[github-actions[bot]]

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

• If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

• If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

• [x] Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

• [x] README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

• [x] Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

• [x] Proper usage of opts table rather than setting things up with the config function.

• [x] Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

[shivanthzen]

Thanks for the revision LGTM.

[zedeus]

For me it doesn't get updated in real-time unlike gopls which already uses e.g. staticcheck for linting. It results in both lingering and duplicated warnings for me: After save: After satisfying the check, before saving:

I'd like either of the following options:

• Improve the golangcilint integration to be real-time without having to edit just like the default LSP is (maybe by using null-ls instead of nvim-lint? I don't know very much about plugin landscape so maybe this is nonsensical)
• A way to easily disable golangcilint (not sure how to go about it, do I have to remove that element from the array in my configuration?)

[mehalter]

@zedeus yeah it might be better for this not to be a default is gopls already has linting. Then users can opt into it. If you open a PR to revert this then I will merge it

[zedeus]

@mehalter here you go: https://github.com/AstroNvim/astrocommunity/pull/1215

[shivanthzen]

The revert makes sense. Is A way to easily disable golangci_lint (not sure how to go about it, do I have to remove that element from the array in my configuration?) this a possbility right now in Astronvim ? Can I override pack configurations ? I only know of override.lua which is sort of per plugin configuration. @mehalter

[mehalter]

yeah you can revert the decision in your user configuration. You would just modify the configuration of the plugins. So go into the opts for nvim-lint for example and remove golangci_lint from the go filetype list

[mehalter]

you can add it anywhere in your plugins/ folder. It doesn't have to go in override.lua