fix(pack): pass `astrolsp.on_attach()` to `moonbit.nvim`

[rami3l]

📑 Description

After installing the moonbit pack, moonbit-lsp still won't launch properly. This looks like an oversight in #1224. (cc @mehalter)

Tested locally with the following override:

  {
    "tonyfettes/moonbit.nvim",
    opts = function(_, opts)
      -- only enable treesitter if the plugin is available
      if not require("astrocore").is_available("nvim-treesitter") then
        opts.treesitter = { enabled = false }
      end
      -- only enable the LSP if the lsp command is executable
      if vim.fn.executable("moonbit-lsp") == 1 then
        local astrolsp_avail, astrolsp = pcall(require, "astrolsp")
        if astrolsp_avail then
          opts.lsp = astrolsp.lsp_opts("moonbit")
          opts.on_attach = astrolsp.on_attach
        end
      else
        opts.lsp = false
      end
    end,
  },

[github-actions[bot]]

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

• If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

• If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

• [ ] Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

• [ ] README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

• [ ] Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

• [ ] Proper usage of opts table rather than setting things up with the config function.

• [ ] Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

[mehalter]

This is incorrect, sorry!

[mehalter]

There is no opts.on_attach option in moonbit.nvim

[mehalter]

I can confirm with a base installation with just this pack as is the moonbit LSP attached correctly

[rami3l]

There is no opts.on_attach option in moonbit.nvim

That's right, my bad :| Maybe I just forgot to restart Neovim so I might be "solving" an inexistent issue...

Thanks again for the quick response :]