Highlights are overriding with `telescope-nvchad-theme`

[snikoletopoulos]

Checklist

• [X] I have searched through the AstroNvim docs
• [X] I have searched through the existing issues of AstroNvim
• [X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

0.9.5 release

Operating system/version

macOS 14.4

Terminal/GUI

WezTerm

Describe the bug

When enabling NVChad telescope theme from AstroNvim Community and having custom unrelated highlights in astroui, the telescope highlights are overriden. Only when i remove my highlights is the theme applied

Steps to Reproduce

1. Add NVChad telescope theme to community
2. Add custom highlights to init different from the telescope, ex. Cmp

Expected behavior

The highlights should merge and both configs are applied

Screenshots

No response

Additional Context

No response

[mehalter]

Please provide some clearer steps for replication and some clear details on the actual behavior and expected behavior

[mehalter]

ah I see what you mean. I believe what you want to do is modify your configuration to play nicely with the telescope nvchad theme pack. Here is an example (assuming you have the telescope-nvchad-theme pack added:

return {
  "AstroNvim/astroui",
  opts = function(_, opts)
    local highlights_init = opts.highlights.init
    return require("astrocore").extend_tbl(opts, {
      highlights = {
        init = function()
          local highlights = type(highlights_init) == "function" and highlights_init() or highlights_init

          -- custom highlights building off of previously modified highlights
          highlights.Normal = { bg = "#ABCDEF" }

          return highlights
        end,
      },
    })
  end,
}

[mehalter]

Also I will move this issue to the AstroCommunity repo

[snikoletopoulos]

Yes thank you. It would be nicer if we didn't have to do all this. I'll continue discussion in the AstroCommunity repo.

[mehalter]

Yeah, limitations of full flexibility means sometimes there is extra syntax

[snikoletopoulos]

@mehalter I tried the code you showed me and it worked. But there is an error with the types and I get the following error. Should I open an issue in the astroui repo?

Also can you re-open the issue now that it is in the astrocommunity repo?

[mehalter]

No this isn't a problem with AstroUI or anything, this is just an issue of you having the wrong type annotation in your config. Check the docs here: https://docs.astronvim.com/configuration/lua_completion/