AstroNvim / astrocommunity

A community repository of common plugin specifications
GNU General Public License v3.0
1.16k stars 238 forks source link

feat(completion): add `copilot-cmp` #967

Closed corintho closed 4 months ago

corintho commented 4 months ago

📑 Description

Adds a new way to integrate copilot with cmp, besides the current options available. This one puts copilot within cmp, instead of setting it up in parallel with it.

github-actions[bot] commented 4 months ago

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

corintho commented 4 months ago

Hi Uzaaft, what do you mean by the naming convention for the folder? I am looking at it and I do not see how it could be any different than the one used, which also sits along with other copilot configurations

corintho commented 4 months ago

Thinking about it further, I think you want me to use copilot-lua-cmp as a plugin folder name. But that name is already taken by another configuration with copilot and cmp. Although that one focus on having copilot outside of cmp, but both of them working together. Mine focus on having copilot show within cmp and a regular completion option

Uzaaft commented 4 months ago

This should be copilot-cmp.

corintho commented 4 months ago

I like it because it is less intrusive, but now I got curious to see how other options perform compared to this one