feat(typescript)!: replace `typescript-tools` with `vtsls`

AstroNvim / astrocommunity

A community repository of common plugin specifications

GNU General Public License v3.0

1.04k stars 214 forks source link

feat(typescript)!: replace `typescript-tools` with `vtsls` #969

Closed mehalter closed 1 month ago

mehalter commented 1 month ago

📑 Description

This moves from typescript-tools.nvim to vtsls language server. Let me know if this is desired, I feel like typescript-tools always has problems with users

ℹ Additional Information

github-actions[bot] commented 1 month ago

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin
If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error
[x] Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above
[x] README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)
[x] Proper usage of opts table rather than setting things up with the config function.

Uzaaft commented 1 month ago

@rafaelderolez @owittek @RayJameson What do you guys think?

RayJameson commented 1 month ago

I don't code TS/JS, so I can't contribute to this discussion

Uzaaft commented 1 month ago

https://github.com/AstroNvim/astrocommunity/issues/974 is proof that this is the way.

owittek commented 1 month ago

not a fan of typescript-tools so feel free to go ahead

Uzaaft commented 1 month ago

Yeah I second this. Lets go ahead and merge this @mehalter . Typescript-tools is just a pain in the ass at this point.

ishwar00 commented 1 month ago

after updating I can't see inlay hints anymore. Am I missing something?

mehalter commented 1 month ago

Hm I thought I configured vtsls with the same inlay hints 🤔 like you don't see them when you toggle them on or you have turned them on by default in AstroLSP? I can check in a bit

gabrielscaranello commented 1 month ago

After the update, cmp and code actions options are duplicated.

mehalter commented 1 month ago

Make sure to uninstall tsserver...

gabrielscaranello commented 1 month ago

Make sure to uninstall tsserver...

It worked correctly after a clean install. Thanks!

ishwar00 commented 1 month ago

Not sure how but it worked when I installed vtsls through Mason.

Thank you.