feat(cpp): add support for linux/arm64

AstroNvim / astrocommunity

A community repository of common plugin specifications

GNU General Public License v3.0

1.04k stars 214 forks source link

feat(cpp): add support for linux/arm64 #997

Closed joshheyse closed 1 month ago

joshheyse commented 1 month ago

📑 Description

Conditionally ensures clangd installed or uses opts.servers for arm64 system

ℹ Additional Information

I'm not familiar with lua / astronvim coding best practices, I'm sure the control flow could be better and interested in learning how to make it more idiomatic.

github-actions[bot] commented 1 month ago

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin
If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error
[ ] Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above
[ ] README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)
[ ] Proper usage of opts table rather than setting things up with the config function.

mehalter commented 1 month ago

There were some bugs, so I cleaned this up and committed it manually, thanks!

Uzaaft commented 1 month ago

Heads up. This possibly breaks stuff for Mac users.

joshheyse commented 1 month ago

Right. Good call.

We need a check for OS too, it should be is_linux_arm.

Sent from my iPhone

On May 27, 2024, at 23:51, Uzair Aftab @.***> wrote:

Heads up. This possibly breaks stuff for Mac users.

— Reply to this email directly, view it on GitHubhttps://github.com/AstroNvim/astrocommunity/pull/997#issuecomment-2134340631, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAKYBPQ72MBUH4OWYEVSBADZEQEN3AVCNFSM6AAAAABILVQ4MSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZUGM2DANRTGE. You are receiving this because you authored the thread.Message ID: @.***>

mehalter commented 1 month ago

should be fixed in latest commit to AstroCommunity

joshheyse commented 1 month ago

@Uzaaft thanks for the catch!

@mehalter thanks for the immediate action!

Sorry for submitting such a glaring issue. I even use macOS for a lot of my development in astronvim. 🤦