Global highlight customizations not working on v2.2.0

[praveenperera]

My theme.lua file

local M = {}

local function config(_, _)
    return {
        palette = "astrodark",
        highlights = {
            global = {
                ["NeogitDiffDeleteHighlight"] = {
                    fg = "#292929",
                    bg = "#f77977",
                },
                ["NeogitDiffAddHighlight"] = {
                    fg = "#292929",
                },
                ["NeogitDiffDelete"] = { fg = "#292929", bg = "#f77977" },
                ["SpelunkerSpellBad"] = { fg = "NONE", bg = "NONE" },
            },
        },
    }
end

M.config = config
return M

init.lua

        {
            "AstroNvim/astrotheme",
            opts = theme.config,
        },

This was working fine until I updated, then the highlight customizations were not working anymore.

Confirmed by downgrading to v2.1.1 customizations working again.

[praveenperera]

Figured it out, had to change how highlights are done, maybe adding a note to the release notes would make sense?

New config

local M = {}

local function config(_, _)
    return {
        palette = "astrodark",
        highlights = {
            global = {
                modify_hl_groups = function(hl, _c)
                    hl.NeogitDiffDeleteHighlight = { fg = "#292929", bg = "#f77977" }
                    hl.NeogitDiffAddHighlight = { fg = "#292929" }
                    hl.NeogitDiffDelete = { fg = "#292929", bg = "#f77977" }
                    hl.SpelunkerSpellBad = { fg = "NONE", bg = "NONE" }
                end,
            },
        },
    }
end

M.config = config
return M

Love the theme changes btw

[A-Lamia]

this is a bug :)

[A-Lamia]

Everything should be merged in later today thanks so much for the report!

[praveenperera]

Well i’m glad I opened the issue then. I wasn’t sure if it was a bug or if I was configuring it wrong. Thanks!