AstroPrint / AstroBox

AstroBox allows you to control your 3D Printer wirelessly
https://www.astroprint.com/products/p/astrobox-software
GNU Affero General Public License v3.0
157 stars 47 forks source link

Feature Request: Chain Gcode Commands (separated by "\n") #91

Open filipgoc opened 8 years ago

filipgoc commented 8 years ago

It would be lovely if the gcode terminal automatically parsed commands separated by semicolons! (Like marlin does internally.)

For example, imagine this gcode chain for calibration purposes:

instead of

G28 (send)
G29 (send)
G1 X50 Y50 F5000 (send)

I'd do

G28; G29; G1 X50 Y50 F5000 (send)
avluis commented 8 years ago

That would definitely be lovely~

CoDanny commented 8 years ago

I thought that anything that follows a ';' is ignored as a comment.

filipgoc commented 8 years ago

@CoDanny of course! I can't even believe what I had said. I got confused with another interface.

updated wish:

I'd happily do

G28\nG29\nG1 X50 Y50 F5000 (send)

MARLIN has a function for parsing commands into new lines ... through deliberate \n at least in the menu. not sure how it's implemented throughout; there's multiple enqueue functions

What about deliberate support for "\n" then? Sounds reasonable! Even typing/pasting multiple lines of codes would in a way work.

PS: in Marlin, the original implementation as per parsing inputs through LCD started here https://github.com/MarlinFirmware/Marlin/pull/1423