AstrobioMike / GToTree

A user-friendly workflow for phylogenomics
GNU General Public License v3.0
199 stars 25 forks source link

adding taxonomy info not working when run in nucleotide mode #91

Closed AstrobioMike closed 4 months ago

AstrobioMike commented 5 months ago

when trying to add NCBI taxonomy information while running in nucleotide mode (-z), it doesn't seem to be pulling the taxid info, as these messages are popping up and there is no tax added in the output alignment or tree files, need to track down why:

 ##############################################################################
 ####                   Adding more informative headers                    ####
 ##############################################################################

  ********************************** NOTICE **********************************
    You specified to use Taxonkit to add lineage info (set with the '-t' flag),
    but there were no taxids available (which typically come from inputs provided
    as NCBI accessions or GenBank files that might hold that information).

    In this case no lineage information could be added.
  *****************************************************************************

  ********************************** NOTICE **********************************
    You specified to swap labels either with a specific mapping file (passed
    to the '-m' flag) and/or by specifying to add NCBI or GTDB taxonomy info,
    but none of these worked out :(

    Genomes from your mapping file may have been filtered out, and there may
    have been no accessible taxonomy information to retrieve (which typically
    would come from inputs provided as NCBI accessions or GenBank files that
    might hold that information).

    In this case no labels could be swapped.
  *****************************************************************************
AstrobioMike commented 4 months ago

look into this line when you can, where it's checking if there are taxids. The else of that if is to print the first "NOTICE" message above. Maybe there is something I missed in nucleotide mode that makes that column be off at that point in the ${output_dir}/Genomes_summary_info.tsv table we're looking at (be sure to kill the run right after there with an exit in the program when testing/looking, so i'm seeing what the file looks like at that point)

AstrobioMike commented 4 months ago

fixed as of v1.8.6