search

Astrocoders / lenses-ppx

GADT lenses
MIT License
105 stars 10 forks source link

Update pipeline.yml #31

Closed savi2w closed 3 years ago

savi2w commented 3 years ago

This PR updates the current CI/CD to npm publish each commit to the master branch In order to everything work we also need a NODE_AUTH_TOKEN secret with a NPM Access Token (Automation)

fakenickels commented 3 years ago

10000% wonderful. Totally forgot to upgrade the actions versions themselves! Great clean up as well 💯💯💯

smorimoto commented 3 years ago

​The recommended styles is:

git config --global user.email "github-actions@github.com"
git config --global user.name "github-actions[bot]"

Alternatively, if you want the actor to be the committer, you can do the following:

git config --global user.email "${GITHUB_ACTOR}@users.noreply.github.com"
git config --global user.name "${GITHUB_ACTOR}"
fakenickels commented 3 years ago

Thanks for the tip! @smorimoto 🙏

smorimoto commented 3 years ago

The current one is a general account that isn't exactly for your bot, so ideally, you should use the one I showed. ​For example, the Actions team uses the same one I showed you :) https://github.com/actions/toolkit/blob/2bf7365352507ee52b4017790934cf9cefabc5f4/.github/workflows/update-github.yaml#L25-L26