Update ppx to use module expression syntax

Astrocoders / lenses-ppx

GADT lenses

MIT License

105 stars 10 forks source link

Update ppx to use module expression syntax #4

Closed baransu closed 5 years ago

baransu commented 5 years ago

Proposal to change the syntax to be less magical. 🧙‍♀️

For me, right now it's not clear what will be the name of the generated module. It's hard to spot newly created modules and IMO it's more natural to have something similar like mhallin/graphql_ppx [%graphql].

fakenickels commented 5 years ago

this is a pretty cool change, totally makes sense for me

fakenickels commented 5 years ago

probably we can even enforce the type to be called t?

fakenickels commented 5 years ago

Merged 🎉